Update package.json.sample#1
Merged
serhii-chernenko merged 1 commit into2.4-developfrom Oct 20, 2023
Merged
Conversation
engcom-Echo
pushed a commit
that referenced
this pull request
Dec 12, 2023
…iven in magento/framework/Setup/Patch/PatchApplier
engcom-Echo
pushed a commit
that referenced
this pull request
Dec 12, 2023
…iven in magento/framework/Setup/Patch/PatchApplier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't even believe that no one didn't comment this PR magento#31618 during 2 year. Do you know that styles sourcemaps are broken since updating this package in

package.json.each time it has to be fixed for a new project.
grunt-contrib-less
1.4.1:grunt-contrib-less

~2.1.0:you ask for self-checking, tests running, screenshots, but don't check the first development steps when you update something. that's weird.
steps to reproduce:
grunt clean:theme && exec:theme && less:theme1.4.1from~2.1.0npm ivideo example that includes the fix (use subtitles) with timecode:
https://youtu.be/NEKvPRTW9mM?si=2f_ZXV-WNR8IyN9N&t=699
that's even funny that in M2.4.7 beta this package is update to
~3.0.0magento@203f415
but it couldn't be compiled with error: